Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix full documentation upload step #4089

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

SMoraisAnsys
Copy link
Collaborator

Problem: it seems that using the new version (v4) of upload-artifact adds some upper bound on the number of files to be uploaded.

Solution: reverting our actions to use v3 and make changes compatible with other ansys actions, i.e. changing some ansys/action/... to v4

Associated issue : actions/upload-artifact#485

Problem: it seems that using the new version (v4) of upload-artifact
adds some upper bound on the number of files to be uploaded.

Solution: reverting our actions to use v3 and make changes compatible
with other ansys actions, i.e. changing some ansys/action/... to v4

Associated issue : actions/upload-artifact#485
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the maintenance Package and maintenance related label Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ecda625) 81.79% compared to head (951a764) 81.85%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4089      +/-   ##
==========================================
+ Coverage   81.79%   81.85%   +0.05%     
==========================================
  Files         184      184              
  Lines       63895    63987      +92     
==========================================
+ Hits        52266    52377     +111     
+ Misses      11629    11610      -19     

@SMoraisAnsys SMoraisAnsys merged commit a7edfe6 into main Jan 17, 2024
14 of 15 checks passed
@SMoraisAnsys SMoraisAnsys deleted the ci/fix_fulldocumentation branch January 17, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants